Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: test cases for registry #14

Merged
merged 24 commits into from
Mar 19, 2024
Merged

feat: test cases for registry #14

merged 24 commits into from
Mar 19, 2024

Conversation

mohandast52
Copy link
Collaborator

@mohandast52 mohandast52 commented Mar 15, 2024 •
edited
Loading

Proposed changes

  • Test cases for the registry app, especially focusing on differentiating between SVM and EVM. There's still a lot more to do and write test cases for, but this is a good start. We'll gradually increase the test cases going forward.
rrrr

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@vercel Vercel
Copy link

vercel bot commented Mar 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
autonolas-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 5:35pm
tokenomics ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 5:35pm

@mohandast52
Copy link
Collaborator Author

@Tanya-atatakai I can build it locally, but I'm encountering an error on Vercel. Any insights on this?

LOCAL

Screenshot

VERCEL

Screensho222

@mohandast52 mohandast52 changed the title (WIP) feat: test cases for registry feat: test cases for registry Mar 19, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 19, 2024

Someone is attempting to deploy this pull request to the autonolas Team on Vercel.

To accomplish this, the commit author's email address needs to be associated with a GitHub account.

Learn more about how to change the commit author information.

Tanya-atatakai
Tanya-atatakai approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@Tanya-atatakai Tanya-atatakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks!

@mohandast52 mohandast52 merged commit d2039f7 into main Mar 19, 2024
7 checks passed
@mohandast52 mohandast52 deleted the mohan/registry-test-cases branch March 19, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@truemiller truemiller truemiller approved these changes

@Tanya-atatakai Tanya-atatakai Tanya-atatakai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohandast52 @Tanya-atatakai @truemiller